Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily drop testing on Py2.7 #8

Merged
merged 11 commits into from
Feb 11, 2024
Merged

Temporarily drop testing on Py2.7 #8

merged 11 commits into from
Feb 11, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 11, 2024

@cclauss cclauss changed the title legacy_python GitHub Action tests Py3.3 thru Py3.7 legacy_python GitHub Action tests PyPy2.7 and Py3.3 thru Py3.7 Feb 11, 2024
@cclauss cclauss changed the title legacy_python GitHub Action tests PyPy2.7 and Py3.3 thru Py3.7 legacy_python GitHub Action tests Py3.3 thru Py3.7 Feb 11, 2024
@jayvdb
Copy link
Owner

jayvdb commented Feb 11, 2024

Im happy to approve and merge if you can get the legacy_python workflow working.

@cclauss
Copy link
Contributor Author

cclauss commented Feb 11, 2024

The problem is that GHA never seems to run the ubuntu-18.04 jobs.

@jayvdb
Copy link
Owner

jayvdb commented Feb 11, 2024

Maybe leave it a day, to see if it runs the ubuntu-18.04 jobs; if not, we know that is no longer a reasonable approach.
I also tried https://github.com/jayvdb/nose3/tree/pyenv, but that didnt appear to work either.
Might need to manually install pyenv and tox to get the "dead" snakes working.

@jayvdb
Copy link
Owner

jayvdb commented Feb 11, 2024

Possibly, just update .github/workflows/tox-gh.yml to what works in that workflow, and leave the other workflow as-is in this PR, and then we can at least get some of the envs working in CI again, and then work on the others in a separate PR

@cclauss cclauss changed the title legacy_python GitHub Action tests Py3.3 thru Py3.7 Drop Py2.7 for now Feb 11, 2024
@cclauss cclauss changed the title Drop Py2.7 for now Temporarily drop testing on Py2.7 Feb 11, 2024
@jayvdb jayvdb merged commit 8f507cc into jayvdb:patches Feb 11, 2024
6 of 8 checks passed
@jayvdb
Copy link
Owner

jayvdb commented Feb 11, 2024

Thanks!

@cclauss cclauss deleted the patch-2 branch February 11, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants